Page MenuHomePhabricator
Differential D19226

When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 7:49 PM.
Tags
None
Referenced Files
F13237819: D19226.diff
Tue, May 21, 3:12 PM
F13226931: D19226.diff
Mon, May 20, 12:15 AM
F13215380: D19226.id.diff
Fri, May 17, 4:56 PM
F13211254: D19226.diff
Fri, May 17, 5:36 AM
F13207400: D19226.id46036.diff
Wed, May 15, 11:09 PM
F13207051: D19226.id.diff
Wed, May 15, 8:32 PM
F13196509: D19226.diff
Sun, May 12, 11:20 PM
Unknown Object (File)
Tue, May 7, 3:35 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13106: Task detail pages are issuing an egregious number of queries?
Commits
rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the…
Summary

See PHI448. Ref T13106. The current implementation here can end up in an infinite stack if, e.g., a project uses "Visible to: Subscribers".

Test Plan

Will push.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2018, 7:49 PM
Harbormaster completed remote builds in B19852: Diff 46035.Mar 14 2018, 7:51 PM
epriestley requested review of this revision.Mar 14 2018, 7:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:59 PM
Closed by commit rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
subscriptions/
policyrule/
7 lines

Diff 46036

View Options

src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php

Loading...
Phabricator · Built by Phacility