When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 7:49 PM.

Details

Reviewers: None
Maniphest Tasks: T13106: Task detail pages are issuing an egregious number of queries?
Commits: rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the…

Summary

See PHI448. Ref T13106. The current implementation here can end up in an infinite stack if, e.g., a project uses "Visible to: Subscribers".

Test Plan

Will push.

Repository

rP Phabricator

Branch

perf7

Lint

Lint Passed

Unit

Tests Passed

Build Status

epriestley requested review of this revision.Mar 14 2018, 7:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:59 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

subscriptions/

policyrule/

7 lines