Page MenuHomePhabricator
Differential D19226

When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 7:49 PM.
Tags
None
Referenced Files
F15467952: D19226.id46035.diff
Thu, Apr 3, 6:41 PM
F15452721: D19226.id.diff
Sat, Mar 29, 6:56 AM
F15451005: D19226.diff
Fri, Mar 28, 7:37 PM
F15421202: D19226.diff
Fri, Mar 21, 9:42 PM
F15397878: D19226.diff
Sun, Mar 16, 10:44 PM
F15380696: D19226.diff
Fri, Mar 14, 4:09 AM
F15379900: D19226.id.diff
Fri, Mar 14, 12:06 AM
Unknown Object (File)
Mar 3 2025, 2:54 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13106: Task detail pages are issuing an egregious number of queries?
Commits
rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the…
Summary

See PHI448. Ref T13106. The current implementation here can end up in an infinite stack if, e.g., a project uses "Visible to: Subscribers".

Test Plan

Will push.

Diff Detail

Repository
rP Phabricator
Branch
perf7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19852
Build 26902: Run Core Tests
Build 26901: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 14 2018, 7:49 PM
Harbormaster completed remote builds in B19852: Diff 46035.Mar 14 2018, 7:51 PM
epriestley requested review of this revision.Mar 14 2018, 7:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:59 PM
Closed by commit rPf348721aed42: When loading project membership to evaluate the "Subscribers" policy, use the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
subscriptions/
policyrule/
7 lines

Diff 46035

View Options

src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php

Loading...
Phabricator · Built by Phacility