Ref T13099. See https://discourse.phabricator-community.org/t/lightbox-not-working/1201. The Content-Security-Policy changes rewrote some of this code and the handling for "Download" links is incorrectly catching clicks on thumbnailed images.
Details
Details
Clicked a thumbnailed image, got a lightbox. Command-clicked a download link, still got link behavior instead of a lightbox.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- lightbox1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19773 Build 26784: Run Core Tests Build 26783: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 288 ms | PhabricatorCelerityTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it.
ACTUAL VALUE
| |
| 1 ms | AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed. | |
| 0 ms | AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message ("") 6 assertions passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message ("") 3 assertions passed. | |
| View Full Test Results (1 Failed · 348 Passed) |