Correct line highlighting behavior in Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 3:04 PM.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rPdab0f84b670d: (stable) Correct line highlighting behavior in Diffusion
rPc6a042b59acf: Correct line highlighting behavior in Diffusion

Summary

See https://discourse.phabricator-community.org/t/line-highlighting-in-diffusion-breaks-url/1207. Ref T13088. This was disrupted by changes for the new Harbormaster build logs and now needs an explicit base URI.

Test Plan

Clicked lines and dragged across line ranges in Diffusion, observed correct URI behavior.

Repository

rP Phabricator

Branch

diffusion1

Lint

Lint Passed

Unit

Tests Passed

Build Status

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 3:05 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

diffusion/

controller/

18 lines