Paths

Table of Contentst

Differential D19186

Return a integer JSON type from "*.edit" endpoints for the object ID
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 2:22 PM.

Tags

None

Referenced Files

	F19920932: D19186.id45954.diff
	Mon, Apr 6, 12:56 AM

	F19903874: D19186.id45954.diff
	Tue, Mar 31, 4:46 AM

	F19897874: D19186.id45953.diff
	Sun, Mar 29, 9:25 AM

	F19892895: D19186.diff
	Sat, Mar 28, 5:03 AM

	F19890772: D19186.diff
	Thu, Mar 26, 7:52 AM

	F19599275: D19186.id45953.diff
	Feb 3 2026, 12:21 AM

	F19599270: D19186.id45953.diff
	Feb 3 2026, 12:20 AM

	F19096176: D19186.id.diff
	Dec 4 2025, 8:28 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP28854ae8121b: Return a integer JSON type from "*.edit" endpoints for the object ID

Summary

See PHI425. See T12678. This should be an integer, but may be a string.

Test Plan

Called differential.revision.edit, observed integer in result instead of string.

Diff Detail

Repository

rP Phabricator

Branch

inttype

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19768
Build 26777: Run Core Tests
Build 26776: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2018, 2:22 PM

Harbormaster completed remote builds in B19768: Diff 45953.Mar 7 2018, 2:23 PM

epriestley requested review of this revision.Mar 7 2018, 2:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 2:27 PM

Closed by commit rP28854ae8121b: Return a integer JSON type from "*.edit" endpoints for the object ID (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editengine/

PhabricatorEditEngine.php

2 lines

Diff 45953

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Return a integer JSON type from "*.edit" endpoints for the object IDClosedPublicActions