Page MenuHomePhabricator

Perform a client-side redirect after OAuth server authorization
ClosedPublic

Authored by epriestley on Mar 6 2018, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 2:15 PM
Unknown Object (File)
Thu, Jan 2, 5:10 PM
Unknown Object (File)
Thu, Jan 2, 5:10 PM
Unknown Object (File)
Thu, Jan 2, 5:09 PM
Unknown Object (File)
Thu, Jan 2, 3:40 PM
Unknown Object (File)
Thu, Jan 2, 1:51 AM
Unknown Object (File)
Dec 18 2024, 6:13 AM
Unknown Object (File)
Dec 7 2024, 3:45 AM
Subscribers
None

Details

Summary

Ref T13099. See that task for discussion. Chrome is unhappy with an MFA form submitting to an endpoint which redirects you to an OAuth URI.

Instead, do the redirect entirely on the client.

Chrome's rationale here isn't obvious, so we may be able to revert this at some point.

Test Plan

Went through the OAuth flow locally, was redirected on the client. Will verify in production.

Diff Detail

Repository
rP Phabricator
Branch
csp1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/behavior-redirect.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 19746
Build 26746: Run Core Tests
Build 26745: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Mar 6 2018, 8:18 PM
This revision was automatically updated to reflect the committed changes.