Page MenuHomePhabricator
Differential D19176

Return commit information for Revision "close" and "update" transactions over the Conduit API
ClosedPublic
Actions

Authored by epriestley on Mar 6 2018, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 2:31 AM
Unknown Object (File)
Thu, Dec 19, 12:11 PM
Unknown Object (File)
Fri, Dec 13, 6:26 AM
Unknown Object (File)
Tue, Dec 3, 9:59 AM
Unknown Object (File)
Sat, Nov 30, 9:12 PM
Unknown Object (File)
Nov 27 2024, 2:00 AM
Unknown Object (File)
Nov 26 2024, 5:44 PM
Unknown Object (File)
Nov 25 2024, 11:33 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13099: Plans: 2018 Week 10 Bonus Content
Commits
rPf3928962096c: Return commit information for Revision "close" and "update" transactions over…
Summary

Depends on D19175. Ref T13099. This fills in "close" and "update" transactions so that they show which commit(s) caused the action.

Test Plan

Used transaction.search to query some revisions, saw commit PHID information.

Diff Detail

Repository
rP Phabricator
Branch
update2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19743
Build 26742: Run Core Tests
Build 26741: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 6 2018, 4:55 PM
Harbormaster completed remote builds in B19743: Diff 45932.Mar 6 2018, 4:56 PM
epriestley requested review of this revision.Mar 6 2018, 4:56 PM
epriestley edited the summary of this revision. (Show Details)Mar 6 2018, 5:11 PM
epriestley added a task: T13099: Plans: 2018 Week 10 Bonus Content.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2018, 5:13 PM
Closed by commit rPf3928962096c: Return commit information for Revision "close" and "update" transactions over… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45932

View Options

src/applications/differential/engine/DifferentialDiffExtractionEngine.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

Loading...
Phabricator · Built by Phacility