Differential D19169

Don't require project edit permission to create a project with members other than yourself
ClosedPublic
Actions

Authored by epriestley on Mar 2 2018, 2:41 AM.

Tags

None

Referenced Files

	F13200373: D19169.id45916.diff
	Mon, May 13, 11:38 PM

	F13195486: D19169.diff
	Sun, May 12, 10:25 PM

	F13179564: D19169.diff
	Wed, May 8, 9:17 PM

	Unknown Object (File)
	Sat, May 4, 6:51 PM

	Unknown Object (File)
	Thu, May 2, 12:27 AM

	Unknown Object (File)
	Wed, May 1, 12:16 AM

	Unknown Object (File)
	Apr 11 2024, 8:42 AM

	Unknown Object (File)
	Mar 31 2024, 2:17 AM

Subscribers

None

Details

Reviewers: None
Commits: rP2121f2dea697: Don't require project edit permission to create a project with members other…

Summary

See PHI193. Previously, see similar D18763. Skip this legacy-style policy check when creating a project, since we know you can add members, even if the policy doesn't actually resolve in your favor.

Test Plan

Created a project with edit policy "Members of project" and myself, plus any other user (so the code goes down this path, not the "join/leave" path) as members.

Diff Detail

Repository

Branch

proj1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19725
Build 26717: Run Core Tests
Build 26716: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 2 2018, 2:41 AM

Harbormaster completed remote builds in B19725: Diff 45916.Mar 2 2018, 2:42 AM

epriestley requested review of this revision.Mar 2 2018, 2:42 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 2:46 AM

Closed by commit rP2121f2dea697: Don't require project edit permission to create a project with members other… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

13 lines

Diff 45916

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...