Page MenuHomePhabricator

Don't require project edit permission to create a project with members other than yourself
ClosedPublic

Authored by epriestley on Mar 2 2018, 2:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 12:12 PM
Unknown Object (File)
Oct 25 2024, 1:17 AM
Unknown Object (File)
Oct 22 2024, 4:22 AM
Unknown Object (File)
Oct 14 2024, 12:59 AM
Unknown Object (File)
Sep 18 2024, 9:00 PM
Unknown Object (File)
Sep 6 2024, 2:39 AM
Unknown Object (File)
Aug 19 2024, 6:24 AM
Unknown Object (File)
Aug 14 2024, 4:51 AM
Subscribers
None

Details

Summary

See PHI193. Previously, see similar D18763. Skip this legacy-style policy check when creating a project, since we know you can add members, even if the policy doesn't actually resolve in your favor.

Test Plan
  • Created a project with edit policy "Members of project" and myself, plus any other user (so the code goes down this path, not the "join/leave" path) as members.

Diff Detail

Repository
rP Phabricator
Branch
proj1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19725
Build 26717: Run Core Tests
Build 26716: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 2:46 AM
This revision was automatically updated to reflect the committed changes.