Differential D19148

Fix a Harbormaster build log issue where too few header lines were returned when expanding logs in the middle
ClosedPublic
Actions

Authored by epriestley on Feb 28 2018, 1:45 PM.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rP985d499f5099: Fix a Harbormaster build log issue where too few header lines were returned…

Summary

Ref T13088. This variable bled through from an earlier loop and caused us to drop some of the lines in the middle.

Test Plan

Clicked "Show More", got an equal number of header and footer lines.

Diff Detail

Repository

rP Phabricator

Branch

harbor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19684
Build 26656: Run Core Tests
Build 26655: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 28 2018, 1:45 PM

Owners added a subscriber: Restricted Owners Package.Feb 28 2018, 1:45 PM

Harbormaster completed remote builds in B19684: Diff 45873.Feb 28 2018, 1:46 PM

epriestley requested review of this revision.Feb 28 2018, 1:46 PM

epriestley added a child revision: D19149: When showing a small piece of a Harbormaster build log, load a small piece of data instead of the entire log.Feb 28 2018, 2:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2018, 8:30 PM

Closed by commit rP985d499f5099: Fix a Harbormaster build log issue where too few header lines were returned… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildLogRenderController.php

4 lines

Diff 45873

View Options

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

Fix a Harbormaster build log issue where too few header lines were returned when expanding logs in the middleClosedPublicActions