Page MenuHomePhabricator
Differential D19128

Fix documentation behaviors for the new proxy functions for custom datasource fields
ClosedPublic
Actions

Authored by epriestley on Feb 22 2018, 8:58 PM.
Tags
None
Referenced Files
F15472669: D19128.id45833.diff
Sat, Apr 5, 3:25 PM
F15467707: D19128.id45833.diff
Thu, Apr 3, 5:27 PM
F15466770: D19128.id45832.diff
Thu, Apr 3, 9:32 AM
F15466534: D19128.id45833.diff
Thu, Apr 3, 6:39 AM
F15464686: D19128.id.diff
Wed, Apr 2, 12:20 PM
F15461797: D19128.diff
Tue, Apr 1, 11:22 AM
F15461534: D19128.diff
Tue, Apr 1, 9:03 AM
F15453495: D19128.diff
Sat, Mar 29, 12:14 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13090: Plans: 2018 Week 8 Bonus Content
Commits
rP8ae01fdc6bf6: Fix documentation behaviors for the new proxy functions for custom datasource…
Summary

Ref T13090. The doc string in "any()" wasn't specified correctly and the help page wasn't getting enough supporting data to build properly.

Test Plan

Viewed "Reference: Advanced Functions" for a custom datasource field and got more helpful help.

Diff Detail

Repository
rP Phabricator
Branch
datasource3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19641
Build 26592: Run Core Tests
Build 26591: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 22 2018, 8:58 PM
Harbormaster completed remote builds in B19641: Diff 45832.Feb 22 2018, 8:59 PM
epriestley requested review of this revision.Feb 22 2018, 8:59 PM
epriestley retitled this revision from Fix document behaviors for the new proxy functions for custom datasource fields to Fix documentation behaviors for the new proxy functions for custom datasource fields.Feb 22 2018, 9:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 9:01 PM
Closed by commit rP8ae01fdc6bf6: Fix documentation behaviors for the new proxy functions for custom datasource… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T13090: Plans: 2018 Week 8 Bonus Content.Feb 22 2018, 9:58 PM

Revision Contents
Changeset List

Diff 45832

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/infrastructure/customfield/datasource/PhabricatorCustomFieldApplicationSearchAnyFunctionDatasource.php

Loading...
Phabricator · Built by Phacility