Paths

Table of Contentst

Differential D19081

Robustly fuse files together with `arc weld`
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 11:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 6:54 AM

	Unknown Object (File)
	Sun, Jan 26, 12:17 PM

	Unknown Object (File)
	Sat, Jan 25, 12:05 AM

	Unknown Object (File)
	Sat, Jan 25, 12:04 AM

	Unknown Object (File)
	Sat, Jan 25, 12:04 AM

	Unknown Object (File)
	Wed, Jan 22, 1:53 PM

	Unknown Object (File)
	Tue, Jan 21, 8:27 PM

	Unknown Object (File)
	Tue, Jan 21, 12:48 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T8236: `arc weld` should do something
Commits: rARC8fe1d7701e5d: (stable) Promote 2018 Week 7
rARCbe1dd7e2ba23: Robustly fuse files together with `arc weld`

Summary

Fixes T8236. I played around with a lot of variations of this but in the end it felt like the simple version was best.

Test Plan

Ran arc weld a.txt b.txt, observed very robust fusion of materials.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19538
Build 26440: Run Core Tests
Build 26439: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2018, 11:12 PM

Harbormaster completed remote builds in B19538: Diff 45736.Feb 13 2018, 11:12 PM

epriestley requested review of this revision.Feb 13 2018, 11:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 11:15 PM

Closed by commit rARCbe1dd7e2ba23: Robustly fuse files together with `arc weld` (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

workflow/

ArcanistWeldWorkflow.php

133 lines

Diff 45736

View Options

src/__phutil_library_map__.php