Differential D19044

Remove red coloration from "Logout" menu item
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 2:16 AM.

Tags

None

Referenced Files

	F13205635: D19044.diff
	Wed, May 15, 2:14 AM

	F13189600: D19044.diff
	Sat, May 11, 6:14 AM

	Unknown Object (File)
	Tue, May 7, 9:53 AM

	Unknown Object (File)
	Mon, May 6, 8:53 AM

	Unknown Object (File)
	Fri, May 3, 9:44 AM

	Unknown Object (File)
	Sat, Apr 27, 7:55 PM

	Unknown Object (File)
	Thu, Apr 25, 3:21 AM

	Unknown Object (File)
	Tue, Apr 23, 9:34 PM

View All 57 Files

Subscribers

None

Details

Reviewers: None
Commits: rP9386e436fe35: Remove red coloration from "Logout" menu item

Summary

I made the red stronger (always visible, not just a hover state) for the "Mute" feature, but this made Logout look a little intense. Just make it normal-colored, logging out isn't a big deal.

Test Plan

No longer saw bright red logout action in profile dropdown menu.

Diff Detail

Repository

rP Phabricator

Branch

logout1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19457
Build 26320: Run Core Tests
Build 26319: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 9 2018, 2:16 AM

Harbormaster completed remote builds in B19457: Diff 45660.Feb 9 2018, 2:17 AM

epriestley requested review of this revision.Feb 9 2018, 2:17 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 1:26 PM

Closed by commit rP9386e436fe35: Remove red coloration from "Logout" menu item (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

engineextension/

PeopleMainMenuBarExtension.php

1 line

Diff 45660

View Options

src/applications/people/engineextension/PeopleMainMenuBarExtension.php

Remove red coloration from "Logout" menu itemClosedPublicActions