Differential D19033

Add "Mute/Unmute" for subscribable objects
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 6:48 PM.

Details

Reviewers: None
Maniphest Tasks: T13053: Plans: Mail Tags and Failover
Commits: rPab04d2179bf1: Add "Mute/Unmute" for subscribable objects

Summary

Ref T13053. See PHI126. Add an explicit "Mute" action to kill mail and notifications for a particular object.

Test Plan

Muted and umuted an object while interacting with it. Saw mail route appropriately.

Diff Detail

Repository

rP Phabricator

Branch

mute1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19433
Build 26284: Run Core Tests
Build 26283: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 8 2018, 6:48 PM

Harbormaster failed remote builds in B19431: Diff 45636!Feb 8 2018, 6:49 PM

Hide these transactions.

Harbormaster failed remote builds in B19432: Diff 45637!Feb 8 2018, 6:52 PM

epriestley mentioned this in T13068: Refinements for "Mute Notifications".Feb 8 2018, 6:55 PM

Only build the mute list if the object is subscribable.

Harbormaster completed remote builds in B19433: Diff 45638.Feb 8 2018, 7:02 PM

epriestley requested review of this revision.Feb 8 2018, 7:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 7:06 PM

Closed by commit rPab04d2179bf1: Add "Mute/Unmute" for subscribable objects (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19034: Remove `addHighlight()` action view methods.Feb 8 2018, 8:13 PM

epriestley mentioned this in rP705ff8d33de0: Remove `addHighlight()` action view methods.Feb 8 2018, 8:15 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

__phutil_library_map__.php

6 lines

applications/

metamta/

query/

PhabricatorMetaMTAActor.php

4 lines

storage/

PhabricatorMetaMTAMail.php

21 lines

subscriptions/

application/

PhabricatorSubscriptionsApplication.php

5 lines

controller/

PhabricatorSubscriptionsMuteController.php

92 lines

events/

PhabricatorSubscriptionsUIEventListener.php

55 lines

transactions/

edges/

PhabricatorMutedByEdgeType.php

16 lines

PhabricatorMutedEdgeType.php

16 lines

editor/

PhabricatorApplicationTransactionEditor.php

28 lines

storage/

PhabricatorApplicationTransaction.php

2 lines

view/

layout/

PhabricatorActionView.php

10 lines

webroot/

rsrc/

css/

phui/

phui-action-list.css

17 lines

Diff 45638

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/metamta/query/PhabricatorMetaMTAActor.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

View Options

src/applications/subscriptions/application/PhabricatorSubscriptionsApplication.php

View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php

View Options

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

View Options

src/applications/transactions/edges/PhabricatorMutedByEdgeType.php

View Options

src/applications/transactions/edges/PhabricatorMutedEdgeType.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

View Options

src/view/layout/PhabricatorActionView.php

View Options

webroot/rsrc/css/phui/phui-action-list.css

Add "Mute/Unmute" for subscribable objectsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45638

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/metamta/query/PhabricatorMetaMTAActor.php

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

src/applications/subscriptions/application/PhabricatorSubscriptionsApplication.php

src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

src/applications/transactions/edges/PhabricatorMutedByEdgeType.php

src/applications/transactions/edges/PhabricatorMutedEdgeType.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

src/view/layout/PhabricatorActionView.php

webroot/rsrc/css/phui/phui-action-list.css

Add "Mute/Unmute" for subscribable objects
ClosedPublic
Actions

Revision Contents
Changeset List