Differential D18589

Return fulltext tokens from the Ferret fulltext engine
ClosedPublic
Actions

Authored by epriestley on Sep 11 2017, 11:38 PM.

Details

Reviewers

chad

Maniphest Tasks

T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size

Commits

rP39b74572e6f7: Return fulltext tokens from the Ferret fulltext engine

Summary

Ref T12819. These render the little "Searched For: X, Y, U V" hint about how something was parsed.

(This might get a "substring" color or "title only" color or something in the future.)

Test Plan

Screen Shot 2017-09-11 at 4.34.54 PM.png (554×576 px, 47 KB)

Diff Detail

Repository

rP Phabricator

Branch

ferret4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18417
Build 24799: Run Core Tests
Build 24798: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2017, 11:38 PM

Harbormaster completed remote builds in B18417: Diff 44634.Sep 11 2017, 11:39 PM

chad accepted this revision.Sep 12 2017, 12:25 AM

This revision is now accepted and ready to land.Sep 12 2017, 12:25 AM

Closed by commit rP39b74572e6f7: Return fulltext tokens from the Ferret fulltext engine (authored by epriestley). · Explain WhySep 12 2017, 1:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

fulltextstorage/

PhabricatorFerretFulltextStorageEngine.php

4 lines

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

11 lines

Diff 44634

View Options

src/applications/search/fulltextstorage/PhabricatorFerretFulltextStorageEngine.php