Page MenuHomePhabricator
Differential D18544

Remove the fulltext "reconstructDocument()" method
ClosedPublic
Actions

Authored by epriestley on Sep 6 2017, 5:50 PM.
Tags
None
Referenced Files
F15470402: D18544.id44548.diff
Fri, Apr 4, 9:48 PM
F15455799: D18544.diff
Sun, Mar 30, 4:55 AM
F15454546: D18544.id44548.diff
Sat, Mar 29, 7:02 PM
F15443233: D18544.id44548.diff
Thu, Mar 27, 3:13 AM
F15441424: D18544.diff
Wed, Mar 26, 6:09 PM
F15436734: D18544.id.diff
Tue, Mar 25, 4:17 PM
F15432649: D18544.diff
Mon, Mar 24, 7:07 PM
F15420455: D18544.id44548.diff
Fri, Mar 21, 2:06 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size
Commits
rPfaca1deea5b5: Remove the fulltext "reconstructDocument()" method
Summary

Ref T12819. This was originally intended for debugging, but never actually used and not clearly useful. There are no callers and it probably does not work. Just get rid of it.

Test Plan

Grepped for callers; none exist.

Diff Detail

Repository
rP Phabricator
Branch
ferret1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18325
Build 24664: Run Core Tests
Build 24663: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 6 2017, 5:50 PM
Harbormaster completed remote builds in B18325: Diff 44542.Sep 6 2017, 5:51 PM
chad accepted this revision.Sep 6 2017, 6:29 PM
This revision is now accepted and ready to land.Sep 6 2017, 6:29 PM
Closed by commit rPfaca1deea5b5: Remove the fulltext "reconstructDocument()" method (authored by epriestley). · Explain WhySep 6 2017, 6:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44542

View Options

src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php

Loading...
View Options

src/applications/search/fulltextstorage/PhabricatorFulltextStorageEngine.php

Loading...
View Options

src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php

Loading...
Phabricator · Built by Phacility