Page MenuHomePhabricator

Render lint patches which have newlines in a less misleading way
ClosedPublic

Authored by epriestley on Aug 31 2017, 7:25 PM.
Tags
None
Referenced Files
F13318475: D18510.diff
Thu, Jun 13, 11:06 AM
F13304731: D18510.id.diff
Sat, Jun 8, 12:14 PM
F13302441: D18510.diff
Sat, Jun 8, 5:06 AM
F13266281: D18510.diff
Tue, May 28, 11:53 AM
F13262903: D18510.diff
Mon, May 27, 4:52 AM
F13250157: D18510.id44459.diff
Fri, May 24, 12:42 PM
F13212327: D18510.diff
May 17 2024, 6:36 AM
F13198809: D18510.id.diff
May 13 2024, 10:03 AM
Subscribers
None

Details

Summary

Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  • Includes test coverage for removing a newline, from T12765.
  • Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  • For one-line patches, highlighting the patched section.
  • For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan

Ran unit tests, linted a few things.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 31 2017, 7:43 PM
This revision was automatically updated to reflect the committed changes.