Page MenuHomePhabricator

Render lint patches which have newlines in a less misleading way
ClosedPublic

Authored by epriestley on Aug 31 2017, 7:25 PM.
Tags
None
Referenced Files
F15414363: D18510.diff
Thu, Mar 20, 12:11 AM
F15386665: D18510.id.diff
Sat, Mar 15, 1:03 AM
F15338249: D18510.id.diff
Sun, Mar 9, 10:08 AM
Unknown Object (File)
Sat, Feb 22, 12:08 AM
Unknown Object (File)
Feb 20 2025, 7:09 AM
Unknown Object (File)
Feb 9 2025, 4:41 AM
Unknown Object (File)
Feb 9 2025, 4:41 AM
Unknown Object (File)
Feb 9 2025, 4:41 AM
Subscribers
None

Details

Summary

Ref T9846. This rewrites the rendering algorithm in a mostly-compatible way and fixes the major issue.

  • Includes test coverage for removing a newline, from T12765.
  • Includes test coverage for mangling an XML tag, from T9846.

This omits two features, which I'll port forward separately:

  • For one-line patches, highlighting the patched section.
  • For zero-line patches, putting a little caret ("^") under the character where the warning occurred.

I'll restore these features in a followup change.

Test Plan

Ran unit tests, linted a few things.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 31 2017, 7:43 PM
This revision was automatically updated to reflect the committed changes.