Page MenuHomePhabricator

Support "-term" in Ferret engine queries
ClosedPublic

Authored by epriestley on Aug 30 2017, 4:55 PM.
Tags
None
Referenced Files
F15466990: D18502.id44434.diff
Thu, Apr 3, 11:31 AM
F15455530: D18502.id44434.diff
Sun, Mar 30, 2:58 AM
F15453713: D18502.id44447.diff
Sat, Mar 29, 1:46 PM
F15443371: D18502.id44434.diff
Thu, Mar 27, 4:04 AM
F15435733: D18502.id.diff
Tue, Mar 25, 10:00 AM
F15431553: D18502.diff
Mon, Mar 24, 1:04 PM
F15425925: D18502.id44447.diff
Sun, Mar 23, 6:39 AM
F15418973: D18502.id44434.diff
Fri, Mar 21, 2:45 AM
Subscribers
None

Details

Summary

Ref T12819. Supports negating search terms, e.g. "apple -honeycrisp".

When negating a term, we're a little more strict about what can match (that is, what can prevent a document from being returned) since it's easy for a user to type "apple -honeycrisp -honey -crisp -crispies -olcrispers -honeyyums" to keep refining their search, but hard/impossible to split apart an overboard term.

Test Plan
  • Ran apple -smith, apple -"granny smith", etc.
  • Verified phone -tact does not exclude phone contact.
  • (In theory, phone -~tact would, but the parser currently doesn't support this, and I'm not champing at the bit to add support.)

Diff Detail

Repository
rP Phabricator
Branch
ferret8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18219
Build 24501: Run Core Tests
Build 24500: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 30 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.