Align first nav item in settings
ClosedPublic
Actions

Authored by chad on Aug 29 2017, 4:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 17, 12:55 AM

	Unknown Object (File)
	Sun, Feb 9, 4:40 AM

	Unknown Object (File)
	Sun, Feb 9, 4:40 AM

	Unknown Object (File)
	Sun, Feb 9, 4:40 AM

	Unknown Object (File)
	Wed, Jan 29, 11:32 AM

	Unknown Object (File)
	Fri, Jan 24, 10:25 PM

	Unknown Object (File)
	Fri, Jan 24, 10:25 PM

	Unknown Object (File)
	Fri, Jan 24, 10:25 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPf3f671aa90ec: Align first nav item in settings

Summary

This removes the redundant "Account" label and item, and just keeps the page better aligned.

Test Plan

Review personal settings

Diff Detail

Repository

rP Phabricator

Branch

account-title (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18200
Build 24473: Run Core Tests
Build 24472: arc lint + arc unit

Event Timeline

chad created this revision.Aug 29 2017, 4:38 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 29 2017, 4:38 PM

Harbormaster completed remote builds in B18200: Diff 44413.Aug 29 2017, 4:39 PM

epriestley accepted this revision.Aug 29 2017, 4:40 PM

This revision is now accepted and ready to land.Aug 29 2017, 4:40 PM

Closed by commit rPf3f671aa90ec: Align first nav item in settings (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 29 2017, 4:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

controller/

PhabricatorSettingsMainController.php

5 lines

panelgroup/

PhabricatorSettingsAccountPanelGroup.php

2 lines

Diff 44413

View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php