Paths

Table of Contentst

Add a missing (int) cast to diff IDs for new "transaction.search" method
ClosedPublic
Actions

Authored by epriestley on Aug 25 2017, 2:25 PM.

Tags

None

Referenced Files

	F15417939: D18476.diff
	Thu, Mar 20, 7:36 PM

	F15389791: D18476.id.diff
	Sat, Mar 15, 5:39 AM

	F15377202: D18476.id44384.diff
	Thu, Mar 13, 8:23 AM

	Unknown Object (File)
	Sun, Mar 2, 1:17 AM

	Unknown Object (File)
	Fri, Feb 21, 3:26 PM

	Unknown Object (File)
	Feb 9 2025, 4:39 AM

	Unknown Object (File)
	Feb 9 2025, 4:39 AM

	Unknown Object (File)
	Feb 9 2025, 4:39 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP213e4ec9b553: Add a missing (int) cast to diff IDs for new "transaction.search" method

Summary

These come out of the database as strings (see T12678), force them to integers for the API.

Test Plan

Called transaction.search, got integers in JSON instead of strings.

Diff Detail

Repository

rP Phabricator

Branch

xaction1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18171
Build 24427: Run Core Tests
Build 24426: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 25 2017, 2:25 PM

Harbormaster completed remote builds in B18171: Diff 44384.Aug 25 2017, 2:26 PM

chad accepted this revision.Aug 25 2017, 2:31 PM

This revision is now accepted and ready to land.Aug 25 2017, 2:31 PM

Closed by commit rP213e4ec9b553: Add a missing (int) cast to diff IDs for new "transaction.search" method (authored by epriestley). · Explain WhyAug 25 2017, 2:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionInlineTransaction.php

2 lines

Diff 44384

View Options

src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php

Add a missing (int) cast to diff IDs for new "transaction.search" methodClosedPublicActions