Have text-less dropdown buttons look better
ClosedPublic
Actions

Authored by chad on Aug 24 2017, 6:54 PM.

Tags

None

Referenced Files

	F18091366: D18461.id.diff
	Wed, Aug 6, 9:17 PM

	F18091158: D18461.id44355.diff
	Wed, Aug 6, 7:50 PM

	F18090673: D18461.id44350.diff
	Wed, Aug 6, 4:51 PM

	F18090622: D18461.id44351.diff
	Wed, Aug 6, 4:27 PM

	F18089785: D18461.diff
	Wed, Aug 6, 12:34 PM

	F18082214: D18461.diff
	Tue, Aug 5, 4:41 AM

	F17672485: D18461.id44355.diff
	Sun, Jul 13, 3:51 AM

	F17657734: D18461.id44350.diff
	Sat, Jul 12, 12:31 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP66613240fa05: Have text-less dropdown buttons look better

Summary

Using icons and dropdown buttons without text looks a little wonky, this resets the CSS a bit.

Test Plan

Review button with icon and text, just icon, just test, and dropdowns.

Diff Detail

Repository

rP Phabricator

Branch

icon-dropdown (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18138
Build 24378: Run Core Tests
Build 24377: arc lint + arc unit

Event Timeline

chad created this revision.Aug 24 2017, 6:54 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 24 2017, 6:54 PM

Harbormaster completed remote builds in B18138: Diff 44350.Aug 24 2017, 6:55 PM

Add some uiexamples

Harbormaster completed remote builds in B18139: Diff 44351.Aug 24 2017, 6:59 PM

epriestley accepted this revision.Aug 24 2017, 7:22 PM

This revision is now accepted and ready to land.Aug 24 2017, 7:22 PM

Closed by commit rP66613240fa05: Have text-less dropdown buttons look better (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 24 2017, 7:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

button/

phui-button.css

6 lines

Diff 44350

View Options

resources/celerity/map.php