Page MenuHomePhabricator

Don't expand folded timelines just because users went to any anchor whatsoever
ClosedPublic

Authored by epriestley on Aug 23 2017, 9:48 PM.
Tags
None
Referenced Files
F19920089: D18458.id.diff
Sun, Apr 5, 12:18 PM
F19713729: D18458.diff
Feb 11 2026, 11:38 PM
F19713728: D18458.diff
Feb 11 2026, 11:38 PM
F19658886: D18458.id.diff
Feb 7 2026, 12:03 AM
F19513933: D18458.id44344.diff
Jan 13 2026, 7:48 PM
F18856311: D18458.id44344.diff
Nov 1 2025, 9:12 AM
F18799275: D18458.id.diff
Oct 17 2025, 12:59 PM
F18790456: D18458.id44346.diff
Oct 15 2025, 2:41 PM
Subscribers
None

Details

Summary

Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits any anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan
  • Viewed a revision with some folded transactions and a "Show Older Comments" link.
  • Clicked a link to a file in the table of contents, with a hash like #1234abcd.
    • Before: Timeline expanded and I ended up somewhere bad.
    • After: Timeline no longer expanded.
  • Manually changed hash to #1234 (purely numeric), saw timeline expand.

Diff Detail

Repository
rP Phabricator
Branch
fold1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18132
Build 24370: Run Core Tests
Build 24369: arc lint + arc unit