Page MenuHomePhabricator

Don't expand folded timelines just because users went to any anchor whatsoever
ClosedPublic

Authored by epriestley on Aug 23 2017, 9:48 PM.
Tags
None
Referenced Files
F13249262: D18458.diff
Fri, May 24, 7:53 AM
F13247274: D18458.diff
Thu, May 23, 5:28 PM
F13229064: D18458.diff
Mon, May 20, 2:07 PM
F13206239: D18458.diff
Wed, May 15, 6:25 AM
F13190166: D18458.diff
Sat, May 11, 7:59 AM
F13174488: D18458.diff
Tue, May 7, 11:24 PM
Unknown Object (File)
May 3 2024, 3:23 PM
Unknown Object (File)
Apr 15 2024, 3:32 PM
Subscribers
None

Details

Summary

Ref T12970. See PHI43. Currently, the "Show Older Comments" link gets auto-clicked if the user visits any anchor. This is not correct.

Instead, only auto-click it if the user visits a numeric anchor. This fixes the behavior approximately 98% of the time. See T12970 for a followup on the remaining ambiguous cases.

Test Plan
  • Viewed a revision with some folded transactions and a "Show Older Comments" link.
  • Clicked a link to a file in the table of contents, with a hash like #1234abcd.
    • Before: Timeline expanded and I ended up somewhere bad.
    • After: Timeline no longer expanded.
  • Manually changed hash to #1234 (purely numeric), saw timeline expand.

Diff Detail

Repository
rP Phabricator
Branch
fold1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18132
Build 24370: Run Core Tests
Build 24369: arc lint + arc unit