Differential D18440

Don't fatal in ElasticSearch setup check if no "master" database is configured
ClosedPublic
Actions

Authored by epriestley on Aug 17 2017, 4:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T12965: When no "master" database is configured, the ElasticSearch setup check can fatal

Commits

rPc9986fd5dee6: Don't fatal in ElasticSearch setup check if no "master" database is configured

Summary

Ref T12965. See that task for discussion, and PHI36 for context.

This sweeps the fatal under the rug by skipping it, letting things move forward for now.

Test Plan

Followed instructions in T12965, got a read-only recovery after restart instead of a fatal.

Diff Detail

Repository

rP Phabricator

Branch

fatal1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/config/check/PhabricatorElasticsearchSetupCheck.php:10	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 18093
Build 24310: Run Core Tests
Build 24309: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 17 2017, 4:53 PM

Harbormaster completed remote builds in B18093: Diff 44302.Aug 17 2017, 4:54 PM

chad accepted this revision.Aug 17 2017, 5:01 PM

This revision is now accepted and ready to land.Aug 17 2017, 5:01 PM

Closed by commit rPc9986fd5dee6: Don't fatal in ElasticSearch setup check if no "master" database is configured (authored by epriestley). · Explain WhyAug 17 2017, 5:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorElasticsearchSetupCheck.php

6 lines

Diff 44302

View Options

src/applications/config/check/PhabricatorElasticsearchSetupCheck.php

Don't fatal in ElasticSearch setup check if no "master" database is configuredClosedPublicActions