Paths

Table of Contentst

Touch up typeahead behavior in locate-file
ClosedPublic
Actions

Authored by chad on Aug 14 2017, 6:20 PM.

Tags

None

Referenced Files

	F14122375: D18424.id44270.diff
	Fri, Nov 29, 5:23 PM

	Unknown Object (File)
	Tue, Nov 26, 11:08 PM

	Unknown Object (File)
	Fri, Nov 22, 8:42 PM

	Unknown Object (File)
	Fri, Nov 22, 7:16 PM

	Unknown Object (File)
	Sun, Nov 17, 11:39 PM

	Unknown Object (File)
	Thu, Nov 14, 12:46 AM

	Unknown Object (File)
	Sun, Nov 10, 2:13 PM

	Unknown Object (File)
	Sat, Nov 9, 2:29 PM

View All 95 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPbd1d22baa21e: Touch up typeahead behavior in locate-file

Summary

Uses fire, underline. Sets text that overflows to ellipsis.

Test Plan

Test searching for CMS in Phabricator. Check other typeaheads, tokenizers.

Diff Detail

Repository

rP Phabricator

Branch

locate-file-css (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18062
Build 24263: Run Core Tests
Build 24262: arc lint + arc unit

Event Timeline

chad created this revision.Aug 14 2017, 6:20 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 14 2017, 6:20 PM

chad edited the test plan for this revision. (Show Details)Aug 14 2017, 6:21 PM

Harbormaster completed remote builds in B18062: Diff 44270.Aug 14 2017, 6:21 PM

epriestley accepted this revision.Aug 14 2017, 6:27 PM

This revision is now accepted and ready to land.Aug 14 2017, 6:27 PM

Closed by commit rPbd1d22baa21e: Touch up typeahead behavior in locate-file (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 14 2017, 6:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

aphront/

typeahead.css

6 lines

Diff 44270

View Options

resources/celerity/map.php