Page MenuHomePhabricator
Differential D18415

Swap transactions and initialization over to modern status constants
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 10:50 PM.
Tags
None
Referenced Files
F15467690: D18415.diff
Thu, Apr 3, 5:21 PM
F15455477: D18415.id44250.diff
Sun, Mar 30, 12:40 AM
F15452467: D18415.id.diff
Sat, Mar 29, 5:02 AM
F15445648: D18415.diff
Thu, Mar 27, 3:14 PM
F15414360: D18415.diff
Thu, Mar 20, 12:11 AM
F15395607: D18415.diff
Sun, Mar 16, 8:21 AM
Unknown Object (File)
Feb 13 2025, 6:50 AM
Unknown Object (File)
Feb 2 2025, 12:59 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rPcd15c2d545ad: Swap transactions and initialization over to modern status constants
Summary

Ref T2543. Update these for the modern stuff.

Test Plan

Created a new revision, got a revision in the right state ("Needs Review"). Accepted, planned, requested, abandoned revision; state transitions looked good.

Diff Detail

Repository
rP Phabricator
Branch
status16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18042
Build 24234: Run Core Tests
Build 24233: arc lint + arc unit

Revision Contents
Changeset List

Diff 44250

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php

Loading...
Phabricator · Built by Phacility