Page MenuHomePhabricator
Differential D18396

Remove legacy `withStatus()` method from RevisionQuery
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:32 PM.
Tags
None
Referenced Files
F17946100: D18396.id.diff
Thu, Jul 31, 1:25 PM
F17933978: D18396.diff
Wed, Jul 30, 9:47 PM
F17844938: D18396.id.diff
Sun, Jul 27, 2:49 AM
F17842701: D18396.id44211.diff
Sun, Jul 27, 12:00 AM
F17822489: D18396.diff
Sat, Jul 26, 3:45 AM
Unknown Object (File)
Thu, Jul 3, 1:13 PM
Unknown Object (File)
Jun 30 2025, 7:18 AM
Unknown Object (File)
Jun 28 2025, 9:13 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP13ddb15bbcfb: Remove legacy `withStatus()` method from RevisionQuery
Summary

Ref T2543. All callsites are now in terms of withStatuses().

Test Plan
  • Called differential.query and differential.find from Conduit API.
  • Grepped through all withStatus() callsites.

Diff Detail

Repository
rP Phabricator
Branch
status5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18009
Build 24189: Run Core Tests
Build 24188: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 4:32 PM
Harbormaster completed remote builds in B18009: Diff 44211.Aug 11 2017, 4:34 PM
chad accepted this revision.Aug 11 2017, 5:13 PM
This revision is now accepted and ready to land.Aug 11 2017, 5:13 PM
Closed by commit rP13ddb15bbcfb: Remove legacy `withStatus()` method from RevisionQuery (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
4 lines
5 lines
constants/
4 lines
query/
32 lines

Diff 44211

View Options

src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php

Loading...
View Options

src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php

Loading...
View Options

src/applications/differential/constants/DifferentialLegacyQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
Phabricator · Built by Phacility