Page MenuHomePhabricator
Differential D18395

Replace legacy Differential queries for "open" revisions with a modern mechanism
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:20 PM.
Tags
None
Referenced Files
F15466004: D18395.id44236.diff
Thu, Apr 3, 12:46 AM
F15460592: D18395.id.diff
Tue, Apr 1, 12:16 AM
F15455990: D18395.id44210.diff
Sun, Mar 30, 6:18 AM
F15447691: D18395.diff
Fri, Mar 28, 1:02 AM
F15414337: D18395.diff
Thu, Mar 20, 12:10 AM
F15408190: D18395.id44236.diff
Tue, Mar 18, 9:36 PM
F15403568: D18395.diff
Tue, Mar 18, 3:55 AM
F15383919: D18395.diff
Mar 14 2025, 6:19 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential
Commits
rP50dfdb8d0355: Replace legacy Differential queries for "open" revisions with a modern mechanism
Summary

Ref T2543. Several queries want only open revisions. Provide a tailored, non-legacy way to issue that query.

Test Plan

Viewed some of these callsites (e.g., "Similar open revisions affecting these files"), saw only open revisions.

Diff Detail

Repository
rP Phabricator
Branch
status4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18008
Build 24187: Run Core Tests
Build 24186: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
2 lines
2 lines
query/
20 lines
2 lines
diffusion/
controller/
2 lines

Diff 44210

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility