Page MenuHomePhabricator
Differential D18336

Switch fluid to fixed on PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Aug 4 2017, 2:51 AM.
Tags
None
Referenced Files
F15412174: D18336.diff
Wed, Mar 19, 11:40 AM
Unknown Object (File)
Feb 9 2025, 4:31 AM
Unknown Object (File)
Feb 9 2025, 4:31 AM
Unknown Object (File)
Feb 9 2025, 4:31 AM
Unknown Object (File)
Feb 9 2025, 4:31 AM
Unknown Object (File)
Feb 4 2025, 7:20 PM
Unknown Object (File)
Jan 27 2025, 12:46 AM
Unknown Object (File)
Jan 26 2025, 10:11 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP68ab9b2642b8: Switch fluid to fixed on PHUITwoColumnView
Summary

We don't ever set fluid, since it already is fluid, also no CSS. Add an actual fixed version.

Test Plan

For use in Instances.

Diff Detail

Repository
rP Phabricator
Branch
fixed-two-column (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17903
Build 24043: Run Core Tests
Build 24042: arc lint + arc unit

Event Timeline

chad created this revision.Aug 4 2017, 2:51 AM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2017, 2:51 AM
Harbormaster completed remote builds in B17903: Diff 44086.Aug 4 2017, 2:52 AM
epriestley accepted this revision.Aug 4 2017, 2:53 AM
This revision is now accepted and ready to land.Aug 4 2017, 2:53 AM
Closed by commit rP68ab9b2642b8: Switch fluid to fixed on PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyAug 4 2017, 2:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
8 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 44086

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility