Cursory research indicates that "login" is a noun, referring to a form, and "log in" is a verb, referring to the action of logging in. I went though every instances of 'login' I could find and tried to clarify all this language. Also, we have "Phabricator" on the registration for like 4-5 times, which is a bit verbose, so I tried to simplify that language as well.
Details
Details
- Reviewers
epriestley - Commits
- rPba4b936dffce: Use Log In vs. Login when it's a verb
Tested logging in and logging out. Pages feel simpler.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- reg-copy (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17880 Build 24012: Run Core Tests Build 24011: arc lint + arc unit
Event Timeline
| src/applications/auth/controller/PhabricatorAuthFinishController.php | ||
|---|---|---|
| 57 | some of these felts they could go either way. | |
| src/applications/auth/controller/PhabricatorAuthFinishController.php | ||
|---|---|---|
| 57 | I think we have a choice here between a gerund and a noun adjunct, but that a verb is not correct, and I'm not sure there's a bright-line rule for making this choice. I can't come up with examples where using another verb sounds correct, e.g. "the run process", "the solve process". I can come up with examples where either a gerund ("the climbing process") or a noun adjunct ("the filtration process") sound okay. I think the gerund here ("the logging in process") sounds much worse than the noun ("the login process"), but I'm not sure there's a rule to select one other than "it sounds wrong". This could also be rephrased as "To complete logging in", or "to complete the process of logging in", or "to complete the login". But I think "login" is more correct than "log in" here. | |
| src/applications/auth/controller/PhabricatorAuthLoginController.php | ||
| 82 | I think "logins" is definitely a noun here, e.g. we would "allow solutions on this install" (noun), not "allow solves on this install" (verb). You could rewrite this as "configured to allow users to log in on this..." if you find that more clear. | |
| 230 | This one is cleaner to me the other way, e.g. "Solution Failed" or "Execution Failed" instead of "Solve Failed" or "Execute Failed". | |
| 260 | I think this is incorrect, e.g. "encountered an error during execution" (noun), or "encountered an error while executing" (gerund), not "encountered an error during execute" (verb). You could use a gerund, "while logging in", like "while executing", but "logging in" generally sounds awkward to my ear. You could rephrase this as a prepositional phrase I guess, "encountered an error while attempting to log in". | |
| src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php | ||
| 90 | As above, this is "Execute Failure" but I think "Execution Failure" is more natural. | |
| src/applications/auth/controller/PhabricatorAuthRegisterController.php | ||
| 485–493 | I think these were intentional because users would do this:
But whatever. | |
| src/applications/auth/controller/PhabricatorAuthStartController.php | ||
| 241 | I think this should be a noun too, "Authentication Required", not "Authenticate Required". | |
| src/applications/auth/controller/PhabricatorAuthValidateController.php | ||
| 71 | As above. | |
| src/applications/auth/provider/PhabricatorLDAPAuthProvider.php | ||
| 322 | I think this one is a noun. You can rephrase as a verb like "You want to restrict the ability to login to a subset of users", but this reads a little awkwardly "to ... to". | |
| 369 | Per above, I think "login process" is more correct, or rephrase as "the process of logging in" or something. | |
| 375 | Per above. | |
Comment Actions
A lot of these weren't really obvious to me either (and I'm not entirely sure I'm correct). And, obviously, I got a bunch wrong in the first place even though I "know" this "rule". The "log in" vs "login" distinction generally feels a bit made up to me and I'd be a little surprised if "Login" wasn't generally recognized as both a noun and a verb a decade from now, like how no one writes "e-mail" with a hyphen anymore.
| src/applications/auth/controller/PhabricatorAuthFinishController.php | ||
|---|---|---|
| 57 | "To complete the login in process" | |
| src/applications/auth/controller/PhabricatorAuthRegisterController.php | ||
| 485–493 | Yeah, it's confusing if we label it, white box it with 'wordmark', or do nothing. I think do nothing is least confusing. At least, it's confusing on Phacility, confusing on Blender, and if we used wordmark, would probably be confusing in other ways. | |
| src/applications/auth/controller/PhabricatorAuthStartController.php | ||
| 241 | Wow I really was asleep at the wheel. | |
Comment Actions
Diffs like this I actually use and like the diff-banner. I do use it to jump comment to comment and make sure I hit them all.
| src/applications/auth/controller/PhabricatorAuthFinishController.php | ||
|---|---|---|
| 57 | that doesnt seem right either. brb | |