Page MenuHomePhabricator

Treat commit hook execution in observed repositories as a no-op, not an error
ClosedPublic

Authored by epriestley on Jul 31 2017, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 2 2025, 7:50 AM
Unknown Object (File)
Jan 31 2025, 9:05 PM
Unknown Object (File)
Jan 31 2025, 1:45 AM
Unknown Object (File)
Jan 3 2025, 3:16 AM
Unknown Object (File)
Dec 28 2024, 12:19 PM
Unknown Object (File)
Dec 27 2024, 6:03 PM
Unknown Object (File)
Dec 22 2024, 12:47 PM
Unknown Object (File)
Dec 19 2024, 1:04 AM
Subscribers
None

Details

Summary

See PHI24. If you create a hosted Mercurial repository and switch it to observed, you can end up with a hook installed that runs on pulls and complains.

Instead, just bail out if we're running on a pull.

The corresponding Git hook doesn't run on pulls, so there's no issue in Git.

Test Plan

Executed the hook in an observed Mercurial repository, got a clean exit.

Diff Detail

Repository
rP Phabricator
Branch
hghook
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17853
Build 23981: Run Core Tests
Build 23980: arc lint + arc unit