Page MenuHomePhabricator
Differential D18299

Add setImage to PHUIActionPanelView
ClosedPublic
Actions

Authored by chad on Jul 30 2017, 7:23 PM.
Tags
None
Referenced Files
F14356881: D18299.diff
Fri, Dec 20, 1:14 AM
Unknown Object (File)
Thu, Dec 19, 1:02 AM
Unknown Object (File)
Tue, Dec 10, 10:17 AM
Unknown Object (File)
Fri, Dec 6, 7:16 PM
Unknown Object (File)
Wed, Nov 27, 9:05 PM
Unknown Object (File)
Tue, Nov 26, 12:25 PM
Unknown Object (File)
Sun, Nov 24, 2:47 AM
Unknown Object (File)
Oct 15 2024, 4:16 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPddd7cbb698cf: Add setImage to PHUIActionPanelView
Summary

Additonal option to use newly made images in these views.

Test Plan

Built an example in UIExamples.

image.png (352×614 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Branch
phui-action-panel (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17838
Build 23958: Run Core Tests
Build 23957: arc lint + arc unit

Event Timeline

chad created this revision.Jul 30 2017, 7:23 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJul 30 2017, 7:23 PM
Harbormaster completed remote builds in B17838: Diff 44000.Jul 30 2017, 7:24 PM
chad edited the test plan for this revision. (Show Details)Jul 30 2017, 7:30 PM
epriestley accepted this revision.Jul 30 2017, 8:20 PM
This revision is now accepted and ready to land.Jul 30 2017, 8:20 PM
Closed by commit rPddd7cbb698cf: Add setImage to PHUIActionPanelView (authored by chad, committed by chad). · Explain WhyJul 30 2017, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
uiexample/
examples/
7 lines
view/
phui/
21 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 44000

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIActionPanelExample.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility