Page MenuHomePhabricator
Differential D18299

Add setImage to PHUIActionPanelView
ClosedPublic
Actions

Authored by chad on Jul 30 2017, 7:23 PM.
Tags
None
Referenced Files
F15424510: D18299.id44000.diff
Sat, Mar 22, 10:48 PM
F15423374: D18299.diff
Sat, Mar 22, 3:14 PM
F15416099: D18299.id44003.diff
Thu, Mar 20, 9:18 AM
F15397844: D18299.diff
Sun, Mar 16, 10:36 PM
F15384239: D18299.id.diff
Fri, Mar 14, 7:14 PM
F15345861: D18299.diff
Mon, Mar 10, 1:00 PM
Unknown Object (File)
Sun, Mar 2, 7:03 PM
Unknown Object (File)
Sat, Feb 22, 6:06 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPddd7cbb698cf: Add setImage to PHUIActionPanelView
Summary

Additonal option to use newly made images in these views.

Test Plan

Built an example in UIExamples.

image.png (352×614 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Branch
phui-action-panel (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17838
Build 23958: Run Core Tests
Build 23957: arc lint + arc unit

Event Timeline

chad created this revision.Jul 30 2017, 7:23 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJul 30 2017, 7:23 PM
Harbormaster completed remote builds in B17838: Diff 44000.Jul 30 2017, 7:24 PM
chad edited the test plan for this revision. (Show Details)Jul 30 2017, 7:30 PM
epriestley accepted this revision.Jul 30 2017, 8:20 PM
This revision is now accepted and ready to land.Jul 30 2017, 8:20 PM
Closed by commit rPddd7cbb698cf: Add setImage to PHUIActionPanelView (authored by chad, committed by chad). · Explain WhyJul 30 2017, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
uiexample/
examples/
7 lines
view/
phui/
21 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 44000

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIActionPanelExample.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility