Page MenuHomePhabricator

Include default severity in XHPAST lint rule list
Needs ReviewPublic

Authored by asherkin on Jul 27 2017, 11:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 3:25 PM
Unknown Object (File)
Jan 21 2025, 10:03 AM
Unknown Object (File)
Jan 17 2025, 7:58 AM
Unknown Object (File)
Jan 15 2025, 7:33 PM
Unknown Object (File)
Dec 27 2024, 8:25 PM
Unknown Object (File)
Dec 17 2024, 4:23 AM
Unknown Object (File)
Dec 13 2024, 4:50 AM
Unknown Object (File)
Dec 13 2024, 4:18 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

I needed a way to see what rules were disabled by default.

Test Plan

Look at arc linters xhpast output.

Diff Detail

Repository
rARC Arcanist
Branch
xhpast-lint-severity (branched from master)
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 17813
Build 23924: Run Core Tests
Build 23923: arc lint + arc unit

Unit TestsFailed

TimeTest
2,044 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
31 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
12 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
12 msArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
4 assertions passed.
12 msArcanistArrayCombineXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 186 Passed · 66 Skipped)