Have Maniphest use create transactions when using email
ClosedPublic
Actions

Authored by chad on Jul 25 2017, 8:28 PM.

Tags

None

Referenced Files

	F14798722: D18279.id43961.diff
	Sat, Jan 25, 6:26 AM

	F14798511: D18279.id43961.diff
	Sat, Jan 25, 6:11 AM

	F14791993: D18279.diff
	Fri, Jan 24, 10:49 PM

	F14791852: D18279.diff
	Fri, Jan 24, 10:36 PM

	F14791464: D18279.id43962.diff
	Fri, Jan 24, 9:59 PM

	F14791463: D18279.id43961.diff
	Fri, Jan 24, 9:59 PM

	F14791462: D18279.id.diff
	Fri, Jan 24, 9:59 PM

	F14791460: D18279.diff
	Fri, Jan 24, 9:59 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12929: Tasks created via email don't get "created" feed stories. They say "renamed"

Commits

rPca17e2283d92: Have Maniphest use create transactions when using email

Summary

Fixes T12929. Sets a create transaction if new.

Test Plan

test a new task over email via command line

Diff Detail

Repository

rP Phabricator

Branch

maniphest-email-create (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17804
Build 23910: Run Core Tests
Build 23909: arc lint + arc unit

Event Timeline

chad created this revision.Jul 25 2017, 8:28 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 25 2017, 8:28 PM

Harbormaster completed remote builds in B17804: Diff 43961.Jul 25 2017, 8:29 PM

I suspect this is correct, should be able to deploy + mail to be sure if the CLI test wasn't totally conclusive.

This revision is now accepted and ready to land.Jul 25 2017, 8:30 PM

Closed by commit rPca17e2283d92: Have Maniphest use create transactions when using email (authored by chad, committed by chad). · Explain WhyJul 25 2017, 8:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

mail/

ManiphestReplyHandler.php

4 lines

Diff 43961

View Options

src/applications/maniphest/mail/ManiphestReplyHandler.php

Have Maniphest use create transactions when using emailClosedPublicActions