Page MenuHomePhabricator

Test 0 and "" cases in Project Icon Config
ClosedPublic

Authored by chad on Jul 10 2017, 6:41 PM.
Tags
None
Referenced Files
F15404187: D18197.id43773.diff
Tue, Mar 18, 6:41 AM
Unknown Object (File)
Wed, Feb 26, 11:45 AM
Unknown Object (File)
Wed, Feb 26, 11:12 AM
Unknown Object (File)
Wed, Feb 26, 11:11 AM
Unknown Object (File)
Feb 9 2025, 4:25 AM
Unknown Object (File)
Feb 9 2025, 4:25 AM
Unknown Object (File)
Feb 9 2025, 4:25 AM
Unknown Object (File)
Feb 9 2025, 4:25 AM
Subscribers

Details

Summary

Better validation for setting a default image in project.icon

Test Plan

Test adding "0" and "" as image options in project.icon, see error.

Diff Detail

Repository
rP Phabricator
Branch
better-checks-config-images (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17663
Build 23714: Run Core Tests
Build 23713: arc lint + arc unit

Event Timeline

(The , null parameter has no effect for any input.)

This revision is now accepted and ready to land.Jul 10 2017, 6:57 PM
This revision was automatically updated to reflect the committed changes.