Fix cancel button on inline comment view
ClosedPublic
Actions

Authored by chad on Jun 13 2017, 5:05 PM.

Tags

None

Referenced Files

	F15523385: D18120.diff
	Mon, Apr 21, 1:04 AM

	F15424072: D18120.id43601.diff
	Mar 22 2025, 8:02 PM

	F15411084: D18120.diff
	Mar 19 2025, 8:49 AM

	F15410208: D18120.diff
	Mar 19 2025, 6:54 AM

	F15409067: D18120.id43594.diff
	Mar 19 2025, 3:09 AM

	F15403725: D18120.diff
	Mar 18 2025, 4:38 AM

	F15391467: D18120.id43601.diff
	Mar 15 2025, 10:04 AM

	Unknown Object (File)
	Feb 18 2025, 5:40 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP21d16c723613: Fix cancel button on inline comment view

Summary

Switch over to PHUIButtonView

Test Plan

Cancel, Edit, Submit new inline diff comment.

Diff Detail

Repository

rP Phabricator

Branch

inline-buttons (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17490
Build 23455: Run Core Tests
Build 23454: arc lint + arc unit

Event Timeline

chad created this revision.Jun 13 2017, 5:05 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 13 2017, 5:05 PM

Harbormaster completed remote builds in B17490: Diff 43594.Jun 13 2017, 5:06 PM

epriestley accepted this revision.Jun 13 2017, 8:39 PM

This revision is now accepted and ready to land.Jun 13 2017, 8:39 PM

Closed by commit rP21d16c723613: Fix cancel button on inline comment view (authored by chad, committed by chad). · Explain WhyJun 13 2017, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentEditView.php

15 lines

Diff 43594

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Fix cancel button on inline comment viewClosedPublicActions