Page MenuHomePhabricator
Differential D18096

More button grey conversions
ClosedPublic
Actions

Authored by chad on Jun 7 2017, 4:31 PM.
Tags
None
Referenced Files
F15477680: D18096.diff
Mon, Apr 7, 5:19 PM
F15461769: D18096.id.diff
Tue, Apr 1, 11:08 AM
F15456035: D18096.id.diff
Sun, Mar 30, 6:35 AM
F15423458: D18096.id43526.diff
Sat, Mar 22, 3:34 PM
F15413005: D18096.id.diff
Wed, Mar 19, 4:19 PM
Unknown Object (File)
Jan 18 2025, 5:17 AM
Unknown Object (File)
Jan 17 2025, 8:56 PM
Unknown Object (File)
Jan 5 2025, 1:06 PM
View All 76 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP38904ea4ad6a: More button grey conversions
Summary

Ran across a few straglers. Convert to the correct color.

Test Plan

grep for profile-image-button, check profile image selection page

Diff Detail

Repository
rP Phabricator
Branch
buttons5 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17426
Build 23362: Run Core Tests
Build 23361: arc lint + arc unit

Event Timeline

chad created this revision.Jun 7 2017, 4:31 PM
Harbormaster completed remote builds in B17426: Diff 43525.Jun 7 2017, 4:31 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJun 7 2017, 4:31 PM
epriestley accepted this revision.Jun 7 2017, 4:32 PM

You might have gotten this already, but I noticed it was missing in the "Edit Subtasks" dialog earlier.

This revision is now accepted and ready to land.Jun 7 2017, 4:32 PM
Harbormaster completed remote builds in B17426: Diff 43525.Jun 7 2017, 4:32 PM
Closed by commit rP38904ea4ad6a: More button grey conversions (authored by chad, committed by chad). · Explain WhyJun 7 2017, 4:34 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jun 7 2017, 5:41 PM

Will look

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
2 lines
files/
controller/
4 lines
people/
controller/
2 lines
phame/
controller/
blog/
2 lines
phortune/
controller/
merchant/
2 lines
project/
controller/
2 lines
4 lines

Diff 43525

View Options

src/applications/conpherence/controller/ConpherenceRoomPictureController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileComposeController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogProfilePictureController.php

Loading...
View Options

src/applications/phortune/controller/merchant/PhortuneMerchantPictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
Phabricator · Built by Phacility