Paths

Table of Contentst

Differential D18054

Have Browse button in History actually work
ClosedPublic
Actions

Authored by chad on May 31 2017, 3:13 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T12780: Icons look bad in HistoryTableView

Commits

rP6295e3785708: Have Browse button in History actually work

Summary

Ref T12780. Makes the button do something useful, like link to the history at the right spot in the graph.

Test Plan

Click on various browse buttons, get correct url.

Diff Detail

Repository

rP Phabricator

Branch

history-icon (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17337
Build 23234: Run Core Tests
Build 23233: arc lint + arc unit

Event Timeline

chad created this revision.May 31 2017, 3:13 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 31 2017, 3:13 AM

Harbormaster completed remote builds in B17337: Diff 43424.May 31 2017, 3:14 AM

epriestley accepted this revision.May 31 2017, 3:14 AM

epriestley added inline comments.

src/applications/diffusion/view/DiffusionView.php
123	setbuttontypedesignstyle

This revision is now accepted and ready to land.May 31 2017, 3:14 AM

You could get rid of the SIMPLE constant too now to actually break setColor(...::SIMPLE).

Closed by commit rP6295e3785708: Have Browse button in History actually work (authored by chad, committed by chad). · Explain WhyMay 31 2017, 3:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionHistoryListView.php

12 lines

DiffusionView.php

14 lines

Diff 43424

View Options

src/applications/diffusion/view/DiffusionHistoryListView.php