Paths

Table of Contentst

Differential D18043

Remove Differential "objectives" UI
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 8:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rPd20221dc7d82: Remove Differential "objectives" UI

Summary

Ref T12733. Completely removes the objectives UI.

Test Plan

Grepped for objective, etc.
Browsed revisions, no JS errors / broken stuff.
(If I missed anything, it's likely to turn up in followup changes.)

Diff Detail

Repository

rP Phabricator

Branch

head1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17311
Build 23194: Run Core Tests
Build 23193: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2017, 8:26 PM

Harbormaster completed remote builds in B17311: Diff 43398.May 30 2017, 8:27 PM

chad accepted this revision.May 30 2017, 10:48 PM

This revision is now accepted and ready to land.May 30 2017, 10:48 PM

Closed by commit rPd20221dc7d82: Remove Differential "objectives" UI (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 12:58 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13514: Restore the Differential "minimap" element.Apr 17 2020, 5:58 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

109 lines

packages.php

3 lines

src/

applications/

differential/

view/

DifferentialChangesetDetailView.php

1 line

DifferentialChangesetListView.php

4 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

34 lines

core/

z-index.css

4 lines

js/

application/

diff/

27 lines

34 lines

90 lines

ScrollObjectiveList.js

differential/

behavior-populate.js

3 lines

Diff 43398

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

View Options

src/applications/differential/view/DifferentialChangesetListView.php

View Options

webroot/rsrc/css/application/differential/changeset-view.css

View Options

webroot/rsrc/css/core/z-index.css

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

View Options

webroot/rsrc/js/application/diff/ScrollObjective.js

View Options

webroot/rsrc/js/application/diff/ScrollObjectiveList.js

View Options

webroot/rsrc/js/application/differential/behavior-populate.js

Remove Differential "objectives" UIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43398

resources/celerity/map.php

resources/celerity/packages.php

src/applications/differential/view/DifferentialChangesetDetailView.php

src/applications/differential/view/DifferentialChangesetListView.php

webroot/rsrc/css/application/differential/changeset-view.css

webroot/rsrc/css/core/z-index.css

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffInline.js

webroot/rsrc/js/application/diff/ScrollObjective.js

webroot/rsrc/js/application/diff/ScrollObjectiveList.js

webroot/rsrc/js/application/differential/behavior-populate.js

Remove Differential "objectives" UI
ClosedPublic
Actions

Revision Contents
Changeset List