Page MenuHomePhabricator
Differential D18041

Detect and prevent invalid configuation of "ui.footer-items"
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 4:32 PM.
Tags
None
Referenced Files
F14121123: D18041.diff
Fri, Nov 29, 11:28 AM
Unknown Object (File)
Wed, Nov 27, 8:55 AM
Unknown Object (File)
Wed, Nov 27, 4:24 AM
Unknown Object (File)
Mon, Nov 25, 3:34 AM
Unknown Object (File)
Sat, Nov 23, 7:19 PM
Unknown Object (File)
Wed, Nov 20, 9:34 PM
Unknown Object (File)
Wed, Nov 20, 7:10 PM
Unknown Object (File)
Sat, Nov 16, 8:02 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12775: InvalidArgumentException in PhabricatorStandardPageView after setting unexpected JSON in ui.footer-items
Commits
rPc4e45c6c8c2e: Detect and prevent invalid configuation of "ui.footer-items"
Summary

Fixes T12775. Currently, we do not validate this option and it's possible to configure it in an invalid way.

Test Plan

Tried to misconfigure things, was helpfully pointed toward errors.

Diff Detail

Repository
rP Phabricator
Branch
config1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17307
Build 23188: Run Core Tests
Build 23187: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2017, 4:32 PM
Harbormaster completed remote builds in B17307: Diff 43394.May 30 2017, 4:33 PM
chad accepted this revision.May 30 2017, 4:38 PM
This revision is now accepted and ready to land.May 30 2017, 4:38 PM
Closed by commit rPc4e45c6c8c2e: Detect and prevent invalid configuation of "ui.footer-items" (authored by epriestley, committed by epriestley). · Explain WhyMay 30 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
config/
custom/
41 lines
option/
3 lines

Diff 43394

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/custom/PhabricatorCustomUIFooterConfigType.php

Loading...
View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...
Phabricator · Built by Phacility