Page MenuHomePhabricator
Differential D18036

Fix lightbox circle icons
ClosedPublic
Actions

Authored by chad on May 27 2017, 12:25 AM.
Tags
None
Referenced Files
F15472196: D18036.id.diff
Sat, Apr 5, 11:19 AM
F15470477: D18036.diff
Fri, Apr 4, 10:45 PM
F15457465: D18036.diff
Sun, Mar 30, 4:59 PM
F15444228: D18036.id43387.diff
Thu, Mar 27, 8:35 AM
F15415803: D18036.id43387.diff
Thu, Mar 20, 7:54 AM
F15414730: D18036.id.diff
Thu, Mar 20, 2:11 AM
F15387822: D18036.id43387.diff
Sat, Mar 15, 2:57 AM
F15335447: D18036.id43387.diff
Sat, Mar 8, 3:26 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPd3b7a0f37c97: (stable) Fix lightbox circle icons
rPe5b3d0331974: Fix lightbox circle icons
Summary

These are unfortunatly manually built so I missed them in testing circle view changes.

Test Plan

Test lightbox, conpherence, uiexamples

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.May 27 2017, 12:25 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 27 2017, 12:25 AM
Harbormaster completed remote builds in B17295: Diff 43383.May 27 2017, 12:26 AM
epriestley accepted this revision.May 27 2017, 3:12 AM
This revision is now accepted and ready to land.May 27 2017, 3:12 AM
Closed by commit rPe5b3d0331974: Fix lightbox circle icons (authored by chad, committed by chad). · Explain WhyMay 27 2017, 3:13 AM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 27 2017, 3:13 AM

This fixes an actual UI issue in lightboxes, not just a UIExample or whatever, right (so I should cherry pick it)?

chad added a comment.May 27 2017, 3:14 AM

Yeah, it does this, which is minor, but a bug.

image.png (154×346 px, 5 KB)

epriestley added a comment.May 27 2017, 3:14 AM

urgently hotfixing all computers in the world

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
page/
3 lines
webroot/
rsrc/
js/
core/
4 lines

Diff 43387

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility