Page MenuHomePhabricator
Differential D18036

Fix lightbox circle icons
ClosedPublic
Actions

Authored by chad on May 27 2017, 12:25 AM.
Tags
None
Referenced Files
F17952092: D18036.id43383.diff
Fri, Aug 1, 1:56 AM
F17890215: D18036.diff
Tue, Jul 29, 3:17 AM
F17887228: D18036.id.diff
Tue, Jul 29, 1:33 AM
F17829992: D18036.id43387.diff
Sat, Jul 26, 10:35 AM
F17794466: D18036.id43383.diff
Thu, Jul 24, 11:51 PM
F17756649: D18036.diff
Tue, Jul 22, 2:33 PM
F17730024: D18036.id43387.diff
Sat, Jul 19, 8:53 PM
F17730020: D18036.id43383.diff
Sat, Jul 19, 8:53 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPd3b7a0f37c97: (stable) Fix lightbox circle icons
rPe5b3d0331974: Fix lightbox circle icons
Summary

These are unfortunatly manually built so I missed them in testing circle view changes.

Test Plan

Test lightbox, conpherence, uiexamples

Diff Detail

Repository
rP Phabricator
Branch
lightbox-icons (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17295
Build 23169: Run Core Tests
Build 23168: arc lint + arc unit

Event Timeline

chad created this revision.May 27 2017, 12:25 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 27 2017, 12:25 AM
Harbormaster completed remote builds in B17295: Diff 43383.May 27 2017, 12:26 AM
epriestley accepted this revision.May 27 2017, 3:12 AM
This revision is now accepted and ready to land.May 27 2017, 3:12 AM
Closed by commit rPe5b3d0331974: Fix lightbox circle icons (authored by chad, committed by chad). · Explain WhyMay 27 2017, 3:13 AM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 27 2017, 3:13 AM

This fixes an actual UI issue in lightboxes, not just a UIExample or whatever, right (so I should cherry pick it)?

chad added a comment.May 27 2017, 3:14 AM

Yeah, it does this, which is minor, but a bug.

image.png (154×346 px, 5 KB)

epriestley added a comment.May 27 2017, 3:14 AM

urgently hotfixing all computers in the world

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
page/
3 lines
webroot/
rsrc/
js/
core/
4 lines

Diff 43383

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility