Page MenuHomePhabricator
Differential D18032

Try layering state icons on PHUICircleIconView
ClosedPublic
Actions

Authored by chad on May 26 2017, 6:43 PM.
Tags
None
Referenced Files
F15463759: D18032.id.diff
Wed, Apr 2, 3:05 AM
F15462376: D18032.diff
Tue, Apr 1, 2:43 PM
F15440174: D18032.id43378.diff
Wed, Mar 26, 11:19 AM
F15429482: D18032.id.diff
Mon, Mar 24, 2:41 AM
F15426926: D18032.id43378.diff
Sun, Mar 23, 11:40 AM
F15426104: D18032.id43378.diff
Sun, Mar 23, 7:08 AM
F15418974: D18032.id43378.diff
Fri, Mar 21, 2:46 AM
F15414268: D18032.diff
Wed, Mar 19, 11:50 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP81809713e078: Try layering state icons on PHUICircleIconView
Summary

I think this is reasonable for my current use case, but stacking icons overally is pretty clunky.

Test Plan

UIExamples

image.png (96×1 px, 16 KB)

Diff Detail

Repository
rP Phabricator
Branch
icon-circle (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17277
Build 23145: Run Core Tests
Build 23144: arc lint + arc unit

Event Timeline

chad created this revision.May 26 2017, 6:43 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 26 2017, 6:43 PM
chad edited the test plan for this revision. (Show Details)May 26 2017, 6:44 PM
Harbormaster completed remote builds in B17277: Diff 43367.May 26 2017, 6:44 PM
epriestley accepted this revision.May 26 2017, 8:11 PM

Looks pretty good to me.

This revision is now accepted and ready to land.May 26 2017, 8:11 PM
Closed by commit rP81809713e078: Try layering state icons on PHUICircleIconView (authored by chad, committed by chad). · Explain WhyMay 26 2017, 8:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
uiexample/
examples/
17 lines
view/
phui/
47 lines
webroot/
rsrc/
css/
phui/
34 lines

Diff 43367

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIIconExample.php

Loading...
View Options

src/view/phui/PHUIIconCircleView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
Phabricator · Built by Phacility