Page MenuHomePhabricator
Differential D17988

Update Phriction Move Away transaction to modular transactions
ClosedPublic
Actions

Authored by chad on May 22 2017, 12:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 4:34 PM
Unknown Object (File)
Sat, Dec 28, 2:20 PM
Unknown Object (File)
Sun, Dec 22, 4:43 AM
Unknown Object (File)
Thu, Dec 5, 12:20 AM
Unknown Object (File)
Nov 29 2024, 7:55 PM
Unknown Object (File)
Nov 29 2024, 10:21 AM
Unknown Object (File)
Nov 27 2024, 5:59 PM
Unknown Object (File)
Nov 24 2024, 6:59 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12625: Update Phriction for Modular Transactions
Commits
rPb164d2d04bcb: Update Phriction Move Away transaction to modular transactions
Summary

Ref T12625

Test Plan

Move a document to a new location, verify the old and new document. Edit both. Grep for MOVE_AWAY

Diff Detail

Repository
rP Phabricator
Branch
move-away-phriction (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17199
Build 23018: Run Core Tests
Build 23017: arc lint + arc unit

Event Timeline

chad created this revision.May 22 2017, 12:54 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 22 2017, 12:54 AM
Harbormaster completed remote builds in B17179: Diff 43260.May 22 2017, 12:55 AM
epriestley accepted this revision.May 22 2017, 10:18 PM
epriestley added inline comments.
src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php
36–38

(This is probably the default value?)

45

$old is unused

55

$old is unused.

This revision is now accepted and ready to land.May 22 2017, 10:18 PM
chad marked 3 inline comments as done.May 22 2017, 10:40 PM
chad updated this revision to Diff 43282.May 22 2017, 10:41 PM
  • comments
Harbormaster completed remote builds in B17199: Diff 43282.May 22 2017, 10:42 PM
Closed by commit rPb164d2d04bcb: Update Phriction Move Away transaction to modular transactions (authored by chad, committed by chad). · Explain WhyMay 22 2017, 10:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
phriction/
editor/
31 lines
storage/
20 lines
xaction/
62 lines

Diff 43282

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
View Options

src/applications/phriction/storage/PhrictionTransaction.php

Loading...
View Options

src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php

Loading...
Phabricator · Built by Phacility