Page MenuHomePhabricator

Fix a diff objective issue where objectives could appear in the wrong place
ClosedPublic

Authored by epriestley on May 20 2017, 12:28 PM.
Tags
None
Referenced Files
F15463767: D17978.id43248.diff
Wed, Apr 2, 3:11 AM
F15462889: D17978.id.diff
Tue, Apr 1, 6:36 PM
F15459052: D17978.diff
Mon, Mar 31, 9:23 AM
F15380994: D17978.id.diff
Fri, Mar 14, 5:22 AM
Unknown Object (File)
Feb 28 2025, 1:36 PM
Unknown Object (File)
Feb 12 2025, 11:16 PM
Unknown Object (File)
Feb 4 2025, 3:34 PM
Unknown Object (File)
Jan 30 2025, 4:10 AM
Subscribers
None

Details

Summary

Ref T12733. When creating a new comment, the objective could appear to far up in the scrollbar because we were anchoring it to an invisible row.

Instead, anchor to the "edit" row while editing.

Test Plan

Created a new comment at the very top of a file, saw "File, Star" icons instead of "Star, File".

Diff Detail

Repository
rP Phabricator
Branch
map5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17143
Build 22940: Run Core Tests
Build 22939: arc lint + arc unit