Page MenuHomePhabricator

Fix a diff objective issue where objectives could appear in the wrong place
ClosedPublic

Authored by epriestley on May 20 2017, 12:28 PM.
Tags
None
Referenced Files
F14804009: D17978.id43235.diff
Sat, Jan 25, 4:33 PM
Unknown Object (File)
Tue, Jan 21, 3:14 PM
Unknown Object (File)
Tue, Jan 21, 11:56 AM
Unknown Object (File)
Fri, Jan 3, 2:08 PM
Unknown Object (File)
Dec 26 2024, 4:15 PM
Unknown Object (File)
Dec 20 2024, 5:49 PM
Unknown Object (File)
Nov 27 2024, 2:49 AM
Unknown Object (File)
Nov 24 2024, 12:26 AM
Subscribers
None

Details

Summary

Ref T12733. When creating a new comment, the objective could appear to far up in the scrollbar because we were anchoring it to an invisible row.

Instead, anchor to the "edit" row while editing.

Test Plan

Created a new comment at the very top of a file, saw "File, Star" icons instead of "Star, File".

Diff Detail

Repository
rP Phabricator
Branch
map5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17143
Build 22940: Run Core Tests
Build 22939: arc lint + arc unit