Page MenuHomePhabricator
Differential D17975

Stop long filenames in objective list tooltips from being cut off
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 11:21 AM.
Tags
None
Referenced Files
F15488561: D17975.diff
Thu, Apr 10, 11:28 PM
F15479679: D17975.diff
Tue, Apr 8, 8:41 AM
F15465941: D17975.id43246.diff
Thu, Apr 3, 12:25 AM
F15465392: D17975.id43232.diff
Wed, Apr 2, 6:07 PM
F15462219: D17975.id.diff
Tue, Apr 1, 1:09 PM
F15459510: D17975.diff
Mon, Mar 31, 1:40 PM
F15455831: D17975.diff
Sun, Mar 30, 5:08 AM
F15430899: D17975.id43246.diff
Mon, Mar 24, 9:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP1bccdd69cb92: (stable) Stop long filenames in objective list tooltips from being cut off
rP8b2a06387dbc: Stop long filenames in objective list tooltips from being cut off
Summary

Ref T12733. Currently, long filenames get cut off at 160px. Instead, don't cut them off.

Test Plan

Before:

Screen Shot 2017-05-20 at 4.17.43 AM.png (121×253 px, 7 KB)

After:

Screen Shot 2017-05-20 at 4.19.03 AM.png (103×332 px, 8 KB)

Diff Detail

Repository
rP Phabricator
Branch
map2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17140
Build 22934: Run Core Tests
Build 22933: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2017, 11:21 AM
Harbormaster completed remote builds in B17140: Diff 43232.May 20 2017, 11:22 AM
chad accepted this revision.May 20 2017, 2:23 PM
This revision is now accepted and ready to land.May 20 2017, 2:23 PM
Closed by commit rP8b2a06387dbc: Stop long filenames in objective list tooltips from being cut off (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
js/
application/
diff/
1 line
core/
6 lines

Diff 43232

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/ScrollObjective.js

Loading...
View Options

webroot/rsrc/js/core/ToolTip.js

Loading...
Phabricator · Built by Phacility