Move inline anchors up, to dolumn-level
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 5:08 PM.

Tags

None

Referenced Files

	F14034406: D17910.diff
	Sun, Nov 10, 12:01 AM

	F14021318: D17910.diff
	Wed, Nov 6, 7:20 AM

	F14018885: D17910.diff
	Tue, Nov 5, 8:26 PM

	F14012531: D17910.id43084.diff
	Fri, Nov 1, 2:35 PM

	F14007984: D17910.id43084.diff
	Tue, Oct 29, 1:42 PM

	F14000531: D17910.id43084.diff
	Thu, Oct 24, 10:34 PM

	F13986501: D17910.id.diff
	Mon, Oct 21, 3:29 AM

	Unknown Object (File)
	Oct 1 2024, 7:48 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T8420: Hidden inlines don't work properly with anchor-based navigation

Commits

rP86b9deb8a9e9: Move inline anchors up, to dolumn-level

Summary

Fixes T8420. Now that hidden inlines no longer fold into a big clump, anchors can just jump to them in a normal way.

Move the anchors up a smidge so thing work.

Test Plan

Clicked an anchor pointed at a hidden inline, ended up in the right place.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 16 2017, 5:08 PM

Harbormaster failed remote builds in B17012: Diff 43084!May 16 2017, 5:09 PM

that was probably me rolling server

chad accepted this revision.May 16 2017, 5:09 PM

This revision is now accepted and ready to land.May 16 2017, 5:09 PM

Closed by commit rP86b9deb8a9e9: Move inline anchors up, to dolumn-level (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

2 lines

Diff 43085

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Move inline anchors up, to dolumn-levelClosedPublicActions