Move inline anchors up, to dolumn-level
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 5:08 PM.

Tags

None

Referenced Files

	F13819071: D17910.diff
	Fri, Sep 20, 11:49 AM

	Unknown Object (File)
	Fri, Sep 6, 11:33 AM

	Unknown Object (File)
	Tue, Sep 3, 8:57 PM

	Unknown Object (File)
	Sun, Sep 1, 12:04 PM

	Unknown Object (File)
	Wed, Aug 28, 4:23 PM

	Unknown Object (File)
	Tue, Aug 27, 3:34 PM

	Unknown Object (File)
	Mon, Aug 26, 2:55 AM

	Unknown Object (File)
	Aug 17 2024, 6:06 AM

View All 91 Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T8420: Hidden inlines don't work properly with anchor-based navigation

Commits

rP86b9deb8a9e9: Move inline anchors up, to dolumn-level

Summary

Fixes T8420. Now that hidden inlines no longer fold into a big clump, anchors can just jump to them in a normal way.

Move the anchors up a smidge so thing work.

Test Plan

Clicked an anchor pointed at a hidden inline, ended up in the right place.

Diff Detail

Repository

rP Phabricator

Branch

inline10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17012
Build 22743: Run Core Tests
Build 22742: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 5:08 PM

Harbormaster failed remote builds in B17012: Diff 43084!May 16 2017, 5:09 PM

that was probably me rolling server

chad accepted this revision.May 16 2017, 5:09 PM

This revision is now accepted and ready to land.May 16 2017, 5:09 PM

Closed by commit rP86b9deb8a9e9: Move inline anchors up, to dolumn-level (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

2 lines

Diff 43084

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Move inline anchors up, to dolumn-levelClosedPublicActions