Move inline anchors up, to dolumn-level
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 5:08 PM.

Tags

None

Referenced Files

	F15446271: D17910.id43085.diff
	Thu, Mar 27, 6:06 PM

	F15440413: D17910.id43084.diff
	Wed, Mar 26, 12:46 PM

	F15436323: D17910.diff
	Tue, Mar 25, 1:26 PM

	F15434475: D17910.id.diff
	Tue, Mar 25, 3:59 AM

	F15430849: D17910.diff
	Mon, Mar 24, 9:16 AM

	F15413558: D17910.diff
	Wed, Mar 19, 7:39 PM

	Unknown Object (File)
	Feb 22 2025, 12:12 AM

	Unknown Object (File)
	Feb 20 2025, 2:28 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T8420: Hidden inlines don't work properly with anchor-based navigation

Commits

rP86b9deb8a9e9: Move inline anchors up, to dolumn-level

Summary

Fixes T8420. Now that hidden inlines no longer fold into a big clump, anchors can just jump to them in a normal way.

Move the anchors up a smidge so thing work.

Test Plan

Clicked an anchor pointed at a hidden inline, ended up in the right place.

Diff Detail

Repository

rP Phabricator

Branch

inline10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17012
Build 22743: Run Core Tests
Build 22742: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 5:08 PM

Harbormaster failed remote builds in B17012: Diff 43084!May 16 2017, 5:09 PM

that was probably me rolling server

chad accepted this revision.May 16 2017, 5:09 PM

This revision is now accepted and ready to land.May 16 2017, 5:09 PM

Closed by commit rP86b9deb8a9e9: Move inline anchors up, to dolumn-level (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

2 lines

Diff 43084

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Move inline anchors up, to dolumn-levelClosedPublicActions