Page MenuHomePhabricator
Differential D17897

Make passing an object to newCurtain optional
ClosedPublic
Actions

Authored by chad on May 16 2017, 2:58 AM.
Tags
None
Referenced Files
F14036971: D17897.id43041.diff
Sun, Nov 10, 1:11 PM
F14036924: D17897.id43077.diff
Sun, Nov 10, 12:56 PM
F14036550: D17897.id.diff
Sun, Nov 10, 10:43 AM
F14023339: D17897.diff
Thu, Nov 7, 1:10 AM
F14004692: D17897.id43041.diff
Sun, Oct 27, 1:16 AM
F13982541: D17897.diff
Sun, Oct 20, 12:03 AM
Unknown Object (File)
Oct 2 2024, 10:41 AM
Unknown Object (File)
Oct 1 2024, 8:21 PM
View All 89 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPbf753c8b5a08: Make passing an object to newCurtain optional
Summary

We seem to already support this, just takes it fully there. We don't need to see things like "Flag", etc, on certain subpages of projects/people/etc.

Test Plan

Review Members, Subproject pages, no longer see "Flag for Later" which only is for the Project itself. Check manage, still there.

Diff Detail

Repository
rP Phabricator
Branch
curtain-object (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16968
Build 22684: Run Core Tests
Build 22683: arc lint + arc unit

Event Timeline

chad created this revision.May 16 2017, 2:58 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 16 2017, 2:58 AM
Harbormaster completed remote builds in B16968: Diff 43041.May 16 2017, 2:59 AM
epriestley accepted this revision.May 16 2017, 9:52 AM
epriestley added inline comments.
src/applications/base/controller/PhabricatorController.php
494–497

Consider skipping this if $object is null -- some extension might run into trouble assuming that $object will always actually be an object.

This revision is now accepted and ready to land.May 16 2017, 9:52 AM
chad added a comment.May 16 2017, 3:49 PM

good call

Closed by commit rPbf753c8b5a08: Make passing an object to newCurtain optional (authored by chad, committed by chad). · Explain WhyMay 16 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
2 lines
project/
controller/
2 lines
2 lines

Diff 43041

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...
Phabricator · Built by Phacility