Page MenuHomePhabricator

Make passing an object to newCurtain optional
ClosedPublic

Authored by chad on May 16 2017, 2:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 11:34 AM
Unknown Object (File)
Mon, Jan 27, 10:35 PM
Unknown Object (File)
Jan 18 2025, 6:42 AM
Unknown Object (File)
Jan 2 2025, 8:48 AM
Unknown Object (File)
Dec 31 2024, 8:45 AM
Unknown Object (File)
Dec 13 2024, 5:03 PM
Unknown Object (File)
Dec 2 2024, 11:41 AM
Unknown Object (File)
Nov 28 2024, 3:33 AM
Subscribers

Details

Summary

We seem to already support this, just takes it fully there. We don't need to see things like "Flag", etc, on certain subpages of projects/people/etc.

Test Plan

Review Members, Subproject pages, no longer see "Flag for Later" which only is for the Project itself. Check manage, still there.

Diff Detail

Repository
rP Phabricator
Branch
curtain-object (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16968
Build 22684: Run Core Tests
Build 22683: arc lint + arc unit

Event Timeline

epriestley added inline comments.
src/applications/base/controller/PhabricatorController.php
494–497

Consider skipping this if $object is null -- some extension might run into trouble assuming that $object will always actually be an object.

This revision is now accepted and ready to land.May 16 2017, 9:52 AM
This revision was automatically updated to reflect the committed changes.