Differential D17896

Only show member/watcher notes on Members page in Projects
ClosedPublic
Actions

Authored by chad on May 16 2017, 2:53 AM.

Details

Reviewers

epriestley

Commits

rPef839192aa5a: Only show member/watcher notes on Members page in Projects

Summary

Restricts the view of the membership privileges to just the Members page itself, and not other pages like Home/Details.

Test Plan

Test Home, Test Members, see correct layouts.

Diff Detail

Repository

rP Phabricator

Branch

members-list-note (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16967
Build 22682: Run Core Tests
Build 22681: arc lint + arc unit

Event Timeline

chad created this revision.May 16 2017, 2:53 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 16 2017, 2:53 AM

Harbormaster completed remote builds in B16967: Diff 43040.May 16 2017, 2:54 AM

epriestley accepted this revision.May 16 2017, 9:50 AM

This revision is now accepted and ready to land.May 16 2017, 9:50 AM

Closed by commit rPef839192aa5a: Only show member/watcher notes on Members page in Projects (authored by chad, committed by chad). · Explain WhyMay 16 2017, 2:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectMembersViewController.php

6 lines

view/

PhabricatorProjectUserListView.php

18 lines

Diff 43040

View Options

src/applications/project/controller/PhabricatorProjectMembersViewController.php